search

flux-framework / flux-sched

Fluxion Graph-based Scheduler
GNU Lesser General Public License v3.0
89 stars 41 forks source link

modules: Move feasibility/satisfiability checking into a new module #1285

Open jacobtkeio opened 2 months ago

jacobtkeio commented 2 months ago

Problem: Feasibility checking takes up a significant amount of sched-fluxion-resource's time that could be better spent on scheduling. Additionally, feasibility checking is not RFC 27 compliant. Solution: Move feasibility checking into a new module, sched-fluxion-feasibility, that can run on multiple ranks and make it RFC 27 compliant.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 72.53259% with 295 lines in your changes missing coverage. Please review.

Project coverage is 75.4%. Comparing base (4d9fc6f) to head (c3d821e).

Files with missing lines Patch % Lines
resource/modules/resource.cpp 70.9% 219 Missing :warning:
resource/modules/feasibility.cpp 69.8% 60 Missing :warning:
resource/modules/resource_match.cpp 85.9% 16 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1285 +/- ## ======================================= Coverage 75.3% 75.4% ======================================= Files 111 114 +3 Lines 15361 15526 +165 ======================================= + Hits 11575 11708 +133 - Misses 3786 3818 +32 ``` | [Files with missing lines](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1285?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework) | Coverage Δ | | |---|---|---| | [qmanager/modules/qmanager.cpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1285?src=pr&el=tree&filepath=qmanager%2Fmodules%2Fqmanager.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-cW1hbmFnZXIvbW9kdWxlcy9xbWFuYWdlci5jcHA=) | `73.3% <ø> (+4.2%)` | :arrow_up: | | [resource/modules/resource\_match.hpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1285?src=pr&el=tree&filepath=resource%2Fmodules%2Fresource_match.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-cmVzb3VyY2UvbW9kdWxlcy9yZXNvdXJjZV9tYXRjaC5ocHA=) | `100.0% <100.0%> (ø)` | | | [resource/modules/resource\_match.cpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1285?src=pr&el=tree&filepath=resource%2Fmodules%2Fresource_match.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-cmVzb3VyY2UvbW9kdWxlcy9yZXNvdXJjZV9tYXRjaC5jcHA=) | `67.2% <85.9%> (-1.8%)` | :arrow_down: | | [resource/modules/feasibility.cpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1285?src=pr&el=tree&filepath=resource%2Fmodules%2Ffeasibility.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-cmVzb3VyY2UvbW9kdWxlcy9mZWFzaWJpbGl0eS5jcHA=) | `69.8% <69.8%> (ø)` | | | [resource/modules/resource.cpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1285?src=pr&el=tree&filepath=resource%2Fmodules%2Fresource.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-cmVzb3VyY2UvbW9kdWxlcy9yZXNvdXJjZS5jcHA=) | `70.9% <70.9%> (ø)` | |