search

flux-framework / flux-sched

Fluxion Graph-based Scheduler
GNU Lesser General Public License v3.0
89 stars 41 forks source link

JGF simplification #1293

Closed jameshcorbett closed 1 month ago

jameshcorbett commented 2 months ago

Posting this as a WIP so I can link to it / work against it in flux-coral2.

jameshcorbett commented 2 months ago

OK, tests are failing, but I think it's generally working properly--the flux-coral2 testsuite runs successfully with the JGF generated from this branch. So remaining work is eliminating the path fields (which will require looking at edges, not sure how to do this yet) and then getting the tests to pass.

jameshcorbett commented 2 months ago

Ok, only t1018-rv1-bootstrap2.t is failing now.

jameshcorbett commented 1 month ago

Thanks, rebased with master, setting MWP.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 72.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 75.3%. Comparing base (a042bbf) to head (6785369). Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
resource/readers/resource_reader_jgf.cpp 67.4% 14 Missing :warning:
src/python/fluxion/resourcegraph/V1.py 78.1% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1293 +/- ## ======================================== - Coverage 75.3% 75.3% -0.1% ======================================== Files 111 111 Lines 15262 15298 +36 ======================================== + Hits 11505 11530 +25 - Misses 3757 3768 +11 ``` | [Files with missing lines](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1293?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework) | Coverage Δ | | |---|---|---| | [resource/readers/resource\_reader\_jgf.hpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1293?src=pr&el=tree&filepath=resource%2Freaders%2Fresource_reader_jgf.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-cmVzb3VyY2UvcmVhZGVycy9yZXNvdXJjZV9yZWFkZXJfamdmLmhwcA==) | `100.0% <ø> (ø)` | | | [src/python/fluxion/resourcegraph/V1.py](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1293?src=pr&el=tree&filepath=src%2Fpython%2Ffluxion%2Fresourcegraph%2FV1.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-c3JjL3B5dGhvbi9mbHV4aW9uL3Jlc291cmNlZ3JhcGgvVjEucHk=) | `86.7% <78.1%> (-5.3%)` | :arrow_down: | | [resource/readers/resource\_reader\_jgf.cpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1293?src=pr&el=tree&filepath=resource%2Freaders%2Fresource_reader_jgf.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-cmVzb3VyY2UvcmVhZGVycy9yZXNvdXJjZV9yZWFkZXJfamdmLmNwcA==) | `70.2% <67.4%> (+0.3%)` | :arrow_up: |