search

flux-framework / flux-sched

Fluxion Graph-based Scheduler
GNU Lesser General Public License v3.0
90 stars 41 forks source link

JGF: default edge subsystem #1297

Closed jameshcorbett closed 2 months ago

jameshcorbett commented 2 months ago

PR #1293 is getting too much (locally anyway, I haven't pushed my changes recently), I need to start smaller.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.2%. Comparing base (2bd4253) to head (29bba93). Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
resource/readers/resource_reader_jgf.cpp 66.6% 1 Missing :warning:
src/python/fluxion/jsongraph/objects/graph.py 0.0% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1297 +/- ## ======================================== - Coverage 75.3% 75.2% -0.1% ======================================== Files 110 110 Lines 15236 15230 -6 ======================================== - Hits 11486 11467 -19 - Misses 3750 3763 +13 ``` | [Files with missing lines](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1297?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework) | Coverage Δ | | |---|---|---| | [src/python/fluxion/resourcegraph/V1.py](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1297?src=pr&el=tree&filepath=src%2Fpython%2Ffluxion%2Fresourcegraph%2FV1.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-c3JjL3B5dGhvbi9mbHV4aW9uL3Jlc291cmNlZ3JhcGgvVjEucHk=) | `91.9% <100.0%> (ø)` | | | [resource/readers/resource\_reader\_jgf.cpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1297?src=pr&el=tree&filepath=resource%2Freaders%2Fresource_reader_jgf.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-cmVzb3VyY2UvcmVhZGVycy9yZXNvdXJjZV9yZWFkZXJfamdmLmNwcA==) | `69.9% <66.6%> (+0.4%)` | :arrow_up: | | [src/python/fluxion/jsongraph/objects/graph.py](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1297?src=pr&el=tree&filepath=src%2Fpython%2Ffluxion%2Fjsongraph%2Fobjects%2Fgraph.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-c3JjL3B5dGhvbi9mbHV4aW9uL2pzb25ncmFwaC9vYmplY3RzL2dyYXBoLnB5) | `47.8% <0.0%> (-2.5%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1297/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework)