search

flux-framework / flux-sched

Fluxion Graph-based Scheduler
GNU Lesser General Public License v3.0
90 stars 41 forks source link

Jgf writer simplification #1299

Closed jameshcorbett closed 1 month ago

jameshcorbett commented 2 months ago

Now that #1293 has made the JGF reader smarter about defaults and the ion-R utility less verbose, the JGF match writer needs similar treatment.

jameshcorbett commented 1 month ago

Ok @trws there is one failing test but I'm pretty sure I know what's wrong and it's just a matter of updating some JGFs after making sure everything looks sane (which is kind of slow since the JSON isn't formatted nicely so requires a lot of manual intervention). If the code looks good to you I could probably get the tests passing in time for the release tomorrow.

jameshcorbett commented 1 month ago

Thanks! Setting MWP

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 67.74194% with 10 lines in your changes missing coverage. Please review.

Project coverage is 75.3%. Comparing base (d21d455) to head (c1af690). Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
resource/writers/match_writers.cpp 67.7% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1299 +/- ## ======================================== - Coverage 75.3% 75.3% -0.1% ======================================== Files 111 111 Lines 15298 15297 -1 ======================================== - Hits 11530 11529 -1 Misses 3768 3768 ``` | [Files with missing lines](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1299?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework) | Coverage Δ | | |---|---|---| | [resource/writers/match\_writers.cpp](https://app.codecov.io/gh/flux-framework/flux-sched/pull/1299?src=pr&el=tree&filepath=resource%2Fwriters%2Fmatch_writers.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flux-framework#diff-cmVzb3VyY2Uvd3JpdGVycy9tYXRjaF93cml0ZXJzLmNwcA==) | `59.5% <67.7%> (-0.1%)` | :arrow_down: |