search

flux-iac / tofu-controller

A GitOps OpenTofu and Terraform controller for Flux
https://flux-iac.github.io/tofu-controller/
Apache License 2.0
1.29k stars 138 forks source link

Makefile and pipline should have pinned versions of dependencies #1269

Open ilithanos opened 7 months ago

ilithanos commented 7 months ago

https://github.com/kubernetes-sigs/controller-runtime/issues/2720

I ran into this breaking our test CI pipelines because of setup-testenv being set to @latest rather than a pinned version. This results in the pipelines breaking due to it updating to a version that needs a newer go version that we currently use.

I've currently pinned the version to version 16, but we need to update at some point in the future.

This issue is also ment as a reminder to not use @latest in general, but use specific pinned versions to ensure consistant builds across runs.

chanwit commented 7 months ago

oh yes a recent PR ran into this issue too. Thank you for bringing this up.

ilithanos commented 7 months ago

@chanwit I basically fixed the case creating that issue as part of the helm chart PR, so it should be fixed in main now.

I would like to leave this issue open until I've had a chance to check if there are any other places without pinned versions.