This release primarily includes a fix that blocked using
filepath-securejoin in Kubernetes.
Previously, some testing mocks we had resulted in us doing import "testing"
in non-_test.go code, which made some downstreams like Kubernetes unhappy.
This has been fixed. (#32)
Thanks to all of the contributors who made this release possible:
This release primarily includes fixes for spurious errors we hit when
checking that directories created by MkdirAll "look right". Upon further
consideration, these checks were fundamentally buggy and didn't offer
any practical protection anyway.
The mode and owner verification logic in MkdirAll has been removed. This
was originally intended to protect against some theoretical attacks but upon
further consideration these protections don't actually buy us anything and
they were causing spurious errors with more complicated filesystem setups.
The "is the created directory empty" logic in MkdirAll has also been
removed. This was not causing us issues yet, but some pseudofilesystems (such
as cgroup) create non-empty directories and so this logic would've been
wrong for such cases.
Thanks to all of the contributors who made this release possible:
This release includes a few fixes for MkdirAll when dealing with S_ISUID
and S_ISGID, to solve a regression runc hit when switching to MkdirAll.
Passing the S_ISUID or S_ISGID modes to MkdirAllInRoot will now return
an explicit error saying that those bits are ignored by mkdirat(2). In
the past a different error was returned, but since the silent ignoring
behaviour is codified in the man pages a more explicit error seems
apt. While silently ignoring these bits would be the most compatible
option, it could lead to users thinking their code sets these bits
when it doesn't. Programs that need to deal with compatibility can
mask the bits themselves. (#23, #25)
Previously, some testing mocks we had resulted in us doing import "testing"
in non-_test.go code, which made some downstreams like Kubernetes unhappy.
This has been fixed. (#32)
[0.3.3] - 2024-09-30
Fixed
The mode and owner verification logic in MkdirAll has been removed. This
was originally intended to protect against some theoretical attacks but upon
further consideration these protections don't actually buy us anything and
they were causing spurious errors with more complicated filesystem setups.
The "is the created directory empty" logic in MkdirAll has also been
removed. This was not causing us issues yet, but some pseudofilesystems (such
as cgroup) create non-empty directories and so this logic would've been
wrong for such cases.
[0.3.2] - 2024-09-13
Changed
Passing the S_ISUID or S_ISGID modes to MkdirAllInRoot will now return
an explicit error saying that those bits are ignored by mkdirat(2). In the
past a different error was returned, but since the silent ignoring behaviour
is codified in the man pages a more explicit error seems apt. While silently
ignoring these bits would be the most compatible option, it could lead to
users thinking their code sets these bits when it doesn't. Programs that need
to deal with compatibility can mask the bits themselves. (#23, #25)
Fixed
If a directory has S_ISGID set, then all child directories will have
S_ISGID set when created and a different gid will be used for any inode
created under the directory. Previously, the "expected owner and mode"
validation in securejoin.MkdirAll did not correctly handle this. We now
correctly handle this case. (#24, #25)
Bumps the go-patch group with 6 updates in the / directory:
1.17.17
1.17.41
0.3.1
0.3.4
1.0.20
1.0.113
1.14.11
1.14.43
0.0.25
0.0.30
1.8.0
1.8.1
Bumps the go-patch group with 2 updates in the /api directory: github.com/go-logr/logr and github.com/onsi/gomega. Bumps the go-patch group with 3 updates in the /tfctl directory: github.com/go-logr/logr, github.com/onsi/gomega and github.com/spf13/cobra.
Updates
github.com/aws/aws-sdk-go-v2/credentials
from 1.17.17 to 1.17.41Commits
0cbb5aa
Release 2024-10-0854c1dd6
Regenerated Clients2cde144
Update endpoints model67fbd35
Update API modelaa04330
Allow non-nil but empty headers (#2826)5a4e5bb
add feature tracking for cbor protocol (#2821)183987c
add annotations to deprecated services and introduce codegen integration for ...b737dc9
Release 2024-10-077279a51
Regenerated Clientsa1b1f5a
Update endpoints modelUpdates
github.com/aws/smithy-go
from 1.20.3 to 1.22.0Changelog
Sourced from github.com/aws/smithy-go's changelog.
... (truncated)
Commits
d479fb7
Release 2024-10-0326886e2
add http client metrics (#543)c175324
Print output when executing commands when exit code != 0 (#540)ec6d6f9
Release 2024-09-253187256
changelogf1f22c5
introduce new aws-http-auth module which implements sigv4 and sigv4a (#541)85dcb19
Release 2024-09-19d2ad136
add tracing and metrics support to generated clients (#538)f0c6adf
Release 2024-08-14f908d96
remove non-runtime changelogUpdates
github.com/cyphar/filepath-securejoin
from 0.3.1 to 0.3.4Release notes
Sourced from github.com/cyphar/filepath-securejoin's releases.
... (truncated)
Changelog
Sourced from github.com/cyphar/filepath-securejoin's changelog.
Commits
fd16ade
VERSION: release v0.3.400e0710
godoc: update package documentation0cd6be1
README: fix reference to open_tree kernel requirements205046f
README: add pkg.go.dev badgeecb1b8e
tests: procfs: clean up mock test hook3ec6eed
CHANGELOG: mention #32 fix86e6182
merge #32 into cyphar/filepath-securejoin:main6864912
Isolate the testing import in test code4348fee
openat: remove unused functiond0c7d67
merge #31 into cyphar/filepath-securejoin:mainUpdates
github.com/elgohr/go-localstack
from 1.0.20 to 1.0.113Commits
5966c11
Merge pull request #983 from elgohr/dependabot/go_modules/github.com/maxbruns...28b89db
Bump github.com/maxbrunsfeld/counterfeiter/v6 from 6.9.0 to 6.10.06d4967d
Merge pull request #982 from elgohr/dependabot/go_modules/docker-c4b95dffb69d08f74
Bump the docker group with 2 updatesf2338a6
Merge pull request #980 from elgohr/dependabot/go_modules/docker-12c74cbbec2a3219b
Bump the docker group with 2 updatese1faedc
Merge pull request #981 from elgohr/dependabot/go_modules/github.com/maxbruns...aa3a744
Bump github.com/maxbrunsfeld/counterfeiter/v6 from 6.8.1 to 6.9.02fc3485
Merge pull request #979 from elgohr/dependabot/go_modules/aws-sdk-6b3fa0658d53cc661
Bump the aws-sdk group with 2 updatesUpdates
github.com/jenkins-x/go-scm
from 1.14.11 to 1.14.43Release notes
Sourced from github.com/jenkins-x/go-scm's releases.
... (truncated)
Commits
b29dca5
chore: release 1.14.437cb6258
chore: add variables4b6f912
Merge pull request #456 from jenkins-x/dependabot/go_modules/github.com/bluek...6189096
chore(deps): bump github.com/bluekeyes/go-gitdiff from 0.7.4 to 0.8.0357a1be
Merge pull request #459 from jenkins-x/pullrequestnull635708f
fix: updating gitea demo url7a98a89
fix: readable diffs96ab517
fix: pull request should be null for issues12239b8
Merge pull request #452 from jenkins-x/dependabot/go_modules/github.com/bluek...2414a0d
Merge pull request #451 from jenkins-x/dependabot/go_modules/k8s.io/apimachin...Updates
github.com/kubescape/go-git-url
from 0.0.25 to 0.0.30Commits
d27eb58
Merge pull request #16 from kubescape/fix-gitlab1ba58cb
use detected host in gitlab apiafc1c54
Merge pull request #15 from kubescape/fix-gitlab29a0174
also support self hosted gitlab in NewGitAPI1d0b89d
Merge pull request #14 from kubescape/fix-gitlabec5afaf
add support for self-hosted gitlab0a7f7ed
Merge pull request #13 from kubescape/fix-gitlab5dd5ab2
fix gitlab project ID generation36432da
Merge pull request #12 from hectorj2f/fix_git_urls_cvee2ce7a0
replace whilp/git-urls module by chainguard-dev/git-urlsUpdates
github.com/maxbrunsfeld/counterfeiter/v6
from 6.9.0 to 6.10.0Release notes
Sourced from github.com/maxbrunsfeld/counterfeiter/v6's releases.
Commits
241cc37
add integration test to validate type aliases are treated correctlyac22042
issue #298 - go 1.23 go/types alias change224623a
Merge pull request #300 from maxbrunsfeld/dependabot/go_modules/golang.org/x/...16e7f66
Bump golang.org/x/tools from 0.25.0 to 0.26.092721d4
Merge pull request #299 from maxbrunsfeld/dependabot/go_modules/golang.org/x/...f5b33b8
Bump golang.org/x/text from 0.18.0 to 0.19.0b15b881
Merge pull request #296 from maxbrunsfeld/dependabot/go_modules/github.com/on...63d30a8
Bump github.com/onsi/gomega from 1.34.1 to 1.34.2Updates
github.com/onsi/gomega
from 1.34.1 to 1.34.2Release notes
Sourced from github.com/onsi/gomega's releases.
Changelog
Sourced from github.com/onsi/gomega's changelog.
Commits
7cabed6
v1.34.2c59c6dc
bump ginkgo as well8158b99
bump to go 1.22 - remove x/exp dependencyfa057b8
v1.34.15e71dcd
Use slices from exp/slices to keep golang 1.20 compatUpdates
github.com/spf13/cobra
from 1.8.0 to 1.8.1Release notes
Sourced from github.com/spf13/cobra's releases.
... (truncated)
Commits
e94f6d0
Address golangci-lint deprecation warnings, enable some more linters (#2152)8003b74
Remove fully inactivated linters (#2148)5c2c1d6
Consistent annotation names (#2140)5a1acea
build(deps): bump github.com/cpuguy83/go-md2man/v2 from 2.0.3 to 2.0.4 (#2127)0fc86c2
docs: update user guide (#2128)6b5f577
More linting (#2099)bd914e5
fix: remove deprecated io/ioutils package (#2120)1f80fa2
chore: remove repetitive words (#2122)c69ae4c
ci: test golang 1.22 (#2113)a30cee5
build(deps): bump actions/cache from 3 to 4 (#2102)Updates
k8s.io/apimachinery
from 0.30.1 to 0.30.3Commits
Updates
github.com/go-logr/logr
from 1.4.1 to 1.4.2Release notes
Sourced from github.com/go-logr/logr's releases.
Commits
1205f42
Merge pull request #295 from go-logr/dependabot/github_actions/actions/checko...ccedcbd
Merge pull request #294 from go-logr/dependabot/github_actions/github/codeql-...bead577
build(deps): bump actions/checkout from 4.1.5 to 4.1.6a492d95
build(deps): bump github/codeql-action from 3.25.4 to 3.25.519ad07c
build(deps): bump ossf/scorecard-action from 2.3.1 to 2.3.31c97a21
build(deps): bump actions/checkout from 4.1.4 to 4.1.5f70c5b5
build(deps): bump github/codeql-action from 3.25.3 to 3.25.44ade8d3
build(deps): bump golangci/golangci-lint-action from 5.3.0 to 6.0.188d98bd
Merge pull request #289 from go-logr/dependabot/github_actions/golangci/golan...432cd86
Merge pull request #288 from go-logr/dependabot/github_actions/actions/setup-...Updates
github.com/onsi/gomega
from 1.34.0 to 1.34.2Release notes
Sourced from github.com/onsi/gomega's releases.
Changelog
Sourced from github.com/onsi/gomega's changelog.
Commits
7cabed6
v1.34.2c59c6dc
bump ginkgo as well8158b99
bump to go 1.22 - remove x/exp dependencyfa057b8
v1.34.15e71dcd
Use slices from exp/slices to keep golang 1.20 compatUpdates
golang.org/x/net
from 0.25.0 to 0.28.0Commits
4542a42
go.mod: update golang.org/x dependencies765c7e8
xsrftoken: create no padding base64 string by RawURLEncoding032e4e4
LICENSE: update per Google Legale2310ae
go.mod: update golang.org/x dependencies77708f7
quic: skip tests which depend on unimplemented UDP functions on Plan 99617c63
http2: avoid Transport hang with Connection: close and AllowHTTP66e838c
go.mod: update golang.org/x dependencies6249541
http2: avoid race in server handler SetReadDeadine/SetWriteDeadline603e3e6
quic: disable X25519Kyber768Draft00 in tests67e8d0c
http2: report an error if goroutines outlive serverTester testsUpdates
github.com/go-logr/logr
from 1.4.1 to 1.4.2Release notes
Sourced from github.com/go-logr/logr's releases.
Commits
1205f42
Merge pull request #295 from go-logr/dependabot/github_actions/actions/checko...ccedcbd
Merge pull request #294 from go-logr/dependabot/github_actions/github/codeql-...bead577
build(deps): bump actions/checkout from 4.1.5 to 4.1.6a492d95
build(deps): bump github/codeql-action from 3.25.4 to 3.25.519ad07c
build(deps): bump ossf/scorecard-action from 2.3.1 to 2.3.31c97a21
build(deps): bump actions/checkout from 4.1.4 to 4.1.5f70c5b5
build(deps): bump github/codeql-action from 3.25.3 to 3.25.44ade8d3
build(deps): bump golangci/golangci-lint-action from 5.3.0 to 6.0.188d98bd
Merge pull request #289 from go-logr/dependabot/github_actions/golangci/golan...432cd86
Merge pull request #288 from go-logr/dependabot/github_actions/actions/setup-...Updates
github.com/onsi/gomega
from 1.34.0 to 1.34.2Release notes
Sourced from github.com/onsi/gomega's releases.
Changelog
Sourced from github.com/onsi/gomega's changelog.
Commits
7cabed6
v1.34.2c59c6dc
Looks like these dependencies are no longer updatable, so this is no longer needed.