fluxcd-community / helm-charts

Community maintained Helm charts for Flux
Apache License 2.0
121 stars 76 forks source link

[BUG] Helm chart for flux2 should allow customize readiness and liveness probes #166

Open slawekww opened 1 year ago

slawekww commented 1 year ago

Describe the bug a clear and concise description of what the bug is.

All modern helm chart allows to define custom readiness and liveness probes. In some k8s deployments, timeout of 1s for not enough.

What's your helm version?

v3.11.1

What's your kubectl version?

v1.24.6

What's the chart version?

2.5.0

What happened?

Readiness/liveness is fixed and cannot be changed by helm chart:

    Liveness:   http-get http://:healthz/healthz delay=0s timeout=1s period=10s #success=1 #failure=3
    Readiness:  http-get http://:http/ delay=0s timeout=1s period=10s #success=1 #failure=3

What you expected to happen?

Add readiness/liveness probes globally for all components or for each components as values.yaml to allow update them by user of helm chart.

How to reproduce it?

Deploy helm chart with flux.

Enter the changed values of values.yaml?

n/a

Enter the command that you execute and failing/misfunctioning.

n/a

Anything else we need to know?

No response