Closed jimid27 closed 1 year ago
Kubernetes version v1.21.1 does not match >=1.24.0-0
We need to bump Kubernetes in e2e tests to kindest/node:v1.24.15
. Can you please do that in
Ok we need to replace:
- name: Setup Kubernetes
uses: engineerd/setup-kind@v0.5.0
with:
version: v0.11.1
With:
- name: Setup Kubernetes
uses: helm/kind-action@v1.4.0
with:
cluster_name: kind
node_image: kindest/node:v1.24.15
with: cluster_name: kind node_image: kindest/node:v1.24.15
Per the README I believe we want to use image
vs node_image
for this action, right?
Something else seems weird with the e2e sync 🤔 as we are creating a cluster named kind
using k8s version 1.24.5
and yet it is still failing (https://github.com/fluxcd-community/helm-charts/actions/runs/5466764719/jobs/9952168866?pr=177#step:4:13)
@jimid27 we need to replace the engineerd/setup-kind@v0.5.0
which is deprecated with helm/kind-action@v1.4.0
like so:
- name: Setup Kubernetes
uses: helm/kind-action@v1.4.0
with:
cluster_name: kind
node_image: kindest/node:v1.24.15
@jimid27 we need to replace the
engineerd/setup-kind@v0.5.0
which is deprecated withhelm/kind-action@v1.4.0
like so:- name: Setup Kubernetes uses: helm/kind-action@v1.4.0 with: cluster_name: kind node_image: kindest/node:v1.24.15
omg my bad I misread your previous post. Change incoming
Works now GG! can you please squash the last 4 commits.
Works now GG! can you please squash the last 4 commits.
should be squashed lmk if theres anything else needed here (or if I messed the squash up 😄 )
Eh the squash didn't work, I can do it at merge time into a single commit.
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
make reviewable