fluxcd-community / helm-charts

Community maintained Helm charts for Flux
Apache License 2.0
121 stars 76 forks source link

Support extraEnv value setting for all flux controllers #179

Closed ravilr closed 1 year ago

ravilr commented 1 year ago

What this PR does / why we need it:

Add extraEnv helm value setting for all flux controllers. source-controller already has this. this change exposes the same across all controllers consistently. In case of using kubeconfig reference in HelmReleases or Kustomizations to reconcile on remote clusters, and in such setups where Kubernetes API endpoints of those remote clusters could require going through an egress proxy for reachability.

Checklist

ravilr commented 1 year ago

@stefanprodan @dwerder PTAL 🙏

ravilr commented 1 year ago

@stefanprodan if you don't mind closing above linked PRs and issues, which are all addressed by this PR. I missed linking the issue here. Thanks.

bpinske commented 1 year ago

While I appreciate this finally being merged upstream, I will admit it's a little irritating that my PR from 7 months ago which is near identical never went anywhere.