search

fluxcd-community / helm-charts

Community maintained Helm charts for Flux
Apache License 2.0
120 stars 72 forks source link

Sharding not possible across namespaces #188

Open drewwells opened 12 months ago

drewwells commented 12 months ago

Describe the bug a clear and concise description of what the bug is.

Cluster resources for RBAC are created with static names, but references namespace specific resources. Given a situation where I install flux into two namespaces a and b. The clusterrolebinding mentions the a/serviceaccount. When I go to install b it attempts to create the same clusterrolebinding but mentions b/serviceaccount.

The simple fix is to include the release name in all cluster wide rbac objects.

What's your helm version?

n/a

What's your kubectl version?

n/a

What's the chart version?

2.9.2

What happened?

No response

What you expected to happen?

No response

How to reproduce it?

Install the chart twice in the same cluster into two separate namespaces.

Enter the changed values of values.yaml?

No response

Enter the command that you execute and failing/misfunctioning.

helm install ... normal steps.

Anything else we need to know?

No response

stefanprodan commented 12 months ago

Flux sharding is not supported by the chart, also deploying to separate namespaces is not how sharding should work. The chart needs to replicate this config: https://fluxcd.io/flux/installation/configuration/sharding/

drewwells commented 12 months ago

I'm using sharding just fine with this chart. I'll submit a PR to remedy this bug.