Fix unittest snapshot file indentation

fluxcd-community / helm-charts

Community maintained Helm charts for Flux

Apache License 2.0

121 stars 76 forks source link

Fix unittest snapshot file indentation #200

Closed tamalsaha closed 12 months ago

tamalsaha commented 12 months ago

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:

Checklist

[x] DCO signed
[x] Chart Version bumped
[x] helm-docs are updated
[x] Helm chart is tested
[ ] Update artifacthub.io/changes in Chart.yaml
[x] Run make reviewable

tamalsaha commented 12 months ago

@stefanprodan , I have updated the snap files. It seems the updated unittest uses different indentation

> helm unittest --file 'tests/*.yaml' charts/flux2/ -u
> helm unittest --file 'tests/*.yaml' charts/flux2-multi-tenancy/ -u
> helm unittest --file 'tests/*.yaml' charts/flux2-notification/ -u

Also, fixed one test for pre-install-job since isNull and isEmpty has different meaning now. https://github.com/helm-unittest/helm-unittest/issues/134#issuecomment-1512099216