fluxcd-community / helm-charts

Community maintained Helm charts for Flux
Apache License 2.0
126 stars 75 forks source link

Implement the patches for Flux All-In-One installation #216

Open kvaps opened 8 months ago

kvaps commented 8 months ago

Is your feature request related to a problem ?

There was a discussion on how to install FluxCD without CNI https://github.com/fluxcd/flux2/discussions/3070

Right now there is no standard and convenient way for doing this.

Describe the solution you'd like.

Add additional option to values.yaml

# -- Implement the patches for Flux All-In-One installation as a single deployable unit (Kubernetes Pod).
# See https://github.com/fluxcd/flux2/discussions/3070
aio: false

Describe alternatives you've considered.

There are certain projects for solving this issue:

I'd like to have a common way to generate a ready manifests to apply.

Additional context.

I can prepare the PR for this feature, but let's first discuss if it is needed and how it should be implemented

cc @stefanprodan @maxpain I would like to hear your opinion as well

maxpain commented 8 months ago

Yes it's a really must have feature.

I deploy Cilium CNI using Flux on a lot of clusters.

gecube commented 1 month ago

@maxpain won't FluxCD operator solve this issue? Anyway, I totally agree, that this option is a must. Particularly I want to highlight that it is not enough to put all fluxCD pods into host network, but also one needs to deal with DNS (as CoreDNS is not working w/o CNI)

maulerjan commented 1 week ago

This is something I'd really like Flux to support in a standardized way. My use-case is RKE2 with Cilium, I can't change Cilium config on the fly right now, as it has to be installed using RKE2's Helm chart installer before Flux. RKE2 has a built-in reconciliation, so it would create conflicts if I had Flux taken over the management of Cilium.

gecube commented 1 week ago

@maulerjan disable cilium chart reconciliation on rke2 level or don't manage it by fluxcd.