Open joedborg opened 1 week ago
Digging into the source, I can see that I might be able to specify this here
https://github.com/fluxcd/flagger/blob/main/cmd/flagger/main.go#L96
...via setting the argument on the Deployment, but it seems that I cannot pass a secrets ref
https://github.com/fluxcd/flagger/blob/main/pkg/metrics/observers/factory.go#L34
Meaning I cannot reach out to an external provider.
Describe the bug
When defining a Canary with Istio, Flagger appears to attempt to use a default Prometheus address.
The custom MetricTemplates can have an endpoint defined, but the default Istio metrics lookups seem to only attempt the default Prometheus address, leading to these errors:
Is it possible to set a custom endpoint with the builtin Istio metrics, or will I have to define all of these myself? It doesn't seem that I can add the
provider
block to Canary spec.To Reproduce
Deploy an Istio backed Canary with an external Prometheus endpoint.
Expected behavior
An endpoint on the CRD to define a custom Prometheus endpoint for Istio.
Additional context