confirm-rollout webhook question

[huanghuangzym]

why confirm-rollout do not have failed time count ? can flagger add feature ,when confirm-rollout failed many times , flagger can roll out to old deployment version?

spec: analysis: interval: 10s maxWeight: 100 metrics:

• name: request-success-rate thresholdRange: min: 99
• name: request-duration thresholdRange: max: 500 stepWeight: 20 stepWeightPromotion: 15 threshold: 10 webhooks:
• name: send event timeout: 10s type: event url: http://asm-controller.cpaas-system:8099/event
• name: approvegate timeout: 10s type: confirm-rollout url: http://asm-controller.cpaas-system:8099/gate/approve service:

i think the approve gate is only stop it ,but can not roll out to old version ? user real need is roll out ?

[stefanprodan]

Manual rollback is possible with a dedicated webhook, see docs: https://docs.flagger.app/usage/webhooks#manual-gating