fluxcd / flagger

Progressive delivery Kubernetes operator (Canary, A/B Testing and Blue/Green deployments)
https://docs.flagger.app
Apache License 2.0
4.85k stars 725 forks source link

Support for specifying the primary deployment name #837

Open jon-walton opened 3 years ago

jon-walton commented 3 years ago

Hello,

We would like to add a -canary suffix to our canary deployment name, using this helm template as an example...

apiVersion: apps/v1
kind: {{ default "Deployment" .Values.deployment.kind }}
metadata:
  {{- if .Values.deployment.canary.enabled }}
  name: {{ include "microservice.fullname" . }}-canary
  {{- else }}
  name: {{ include "microservice.fullname" . }}
  {{- end }}

What we are wanting/trying to achieve is

What flagger actually creates is a deployment my-app-canary-primary

Would you be open to adding an option to the canary CRD allowing us to define the primary's deployment name? in which case we would set it to {{ include "microservice.fullname" . }} resulting in flagger creating my-app-primary

Thanks

panovmikhail commented 1 year ago

Hello. Someone solve this issue? I need rename my deployments too