fluxcd / flux

Successor: https://github.com/fluxcd/flux2
https://fluxcd.io
Apache License 2.0
6.9k stars 1.08k forks source link

Incorrect git-url configured when using https #3202

Closed linuxbsdfreak closed 4 years ago

linuxbsdfreak commented 4 years ago

Describe the bug

The flux pod starts with incorrect string with https as data source and the password is not masked.

To Reproduce

Steps to reproduce the behaviour:

  1. I am installing flux via the helm terraform provider

Expected behavior

url=https://username@github.com/repo/path/gitops-helm-release-tf.git branch=master

A clear and concise description of what you expected to happen.

Logs

Flag --git-verify-signatures has been deprecated, changed to --git-verify-signatures-mode, use that instead
ts=2020-07-20T10:31:18.492774026Z caller=main.go:259 version=1.20.0
ts=2020-07-20T10:31:18.492829538Z caller=main.go:412 msg="using kube config: \"/root/.kube/config\" to connect to the cluster"
ts=2020-07-20T10:31:18.735603088Z caller=main.go:492 component=cluster identity=/var/fluxd/keygen/identity
ts=2020-07-20T10:31:18.735817685Z caller=main.go:493 component=cluster identity.pub="ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABgQC8oCK2OaIYhrMtGqPdE4MkgSyS1jwrc3fCJskvDD9qkoJ0DHfR57O1t7322wYSaVc0J0rP5uAh+0dfBFJoHyV3w5Mjl0RbysEu+Srw0JBNDoQLQo8YIF35EWvxlTD0d08ijDQcxM07GeLool8CN5zpqLTJ6nDcmuVT6tMq5sKDpHR6q4ccSNnHQNu8ChCfCILSvHzNYR93T3SapEorP5RaguBFky9E5do7lXEuvI5SpJG5Nyt8/hITa99Ra4gkfFJrNspij8XGr4lQmplmHyNsMxOGE5FmXYfMRxhCheWGYr0yKLecqf+9zxU06ozFIfIa1WJ2dWke11aQypSqfh8PKWQZ4+3tSu8Nr7SxU50K9rh+1dGJRtfiwRJG+eAuRTerD47O3+v7aXRWDAAFw5bkDsv2NBb9xE/grJL8cQQ4VE+4Rd+TilY9GdmPpThJ4D3yAwzJuq8WKyG/F0eY1OIUKTfNUe8bbUhTcc7naZCG+glxCbv0b3uYsZS1lbfCc/E= root@flux-56fcc77c6c-v2cp6"
ts=2020-07-20T10:31:18.735979558Z caller=main.go:498 host=https://100.64.0.1:443 version=kubernetes-v1.18.4
ts=2020-07-20T10:31:18.736148349Z caller=main.go:510 kubectl=/usr/local/bin/kubectl
ts=2020-07-20T10:31:18.738077811Z caller=main.go:527 ping=true
ts=2020-07-20T10:31:18.739487853Z caller=main.go:666 **url=ssh://@https//USER:TOKEN@github.com/repo/path/gitops-helm-release-tf.git** user="Flux Operator" email=kevin.fernandes@example.com signing-key= verify-signatures-mode=none sync-tag=shoot--example--test state=git readonly=false registry-disable-scanning=false notes-ref=shoot--example--test set-author=false git-secret=false sops=false
ts=2020-07-20T10:31:18.739541405Z caller=main.go:772 upstream="no upstream URL given"
ts=2020-07-20T10:31:18.741405467Z caller=main.go:795 addr=:3030
ts=2020-07-20T10:31:18.742866051Z caller=loop.go:108 component=sync-loop err="loading last-synced resources: git repo not ready: git repo has not been cloned yet"
ts=2020-07-20T10:31:18.743012309Z caller=images.go:17 component=sync-loop msg="polling for new images for automated workloads"
ts=2020-07-20T10:31:18.744214183Z caller=images.go:27 component=sync-loop msg="no automated workloads"
ts=2020-07-20T10:31:19.104067142Z caller=checkpoint.go:24 component=checkpoint msg="up to date" latest=1.20.0
ts=2020-07-20T10:31:19.916446208Z caller=memcached.go:112 component=memcached err="Fetching tag from memcache: memcache: connect timeout to 100.70.154.245:11211"
ts=2020-07-20T10:31:19.916510717Z caller=warming.go:162 component=warmer canonical_name=eu.gcr.io/sap-se-gcr-k8s-public/quay_io/k8scsi/livenessprobe@sha256 auth={map[]} err="fetching previous result from cache: memcache: connect timeout to 100.70.154.245:11211"

Pod Arguments

Containers:
  flux:
    Container ID:  docker://cbc4027220b3659c3bcd3ee0f435d7664b57824ef836c93abe7767c1db304096
    Image:         docker.io/fluxcd/flux:1.20.0
    Image ID:      docker-pullable://fluxcd/flux@sha256:9f6ce4bfe9f9f1e743bc1e15c524f20c5e07bbd9c1d49f0709c0b73a134789c2
    Port:          3030/TCP
    Host Port:     0/TCP
    Args:
      --log-format=fmt
      --ssh-keygen-dir=/var/fluxd/keygen
      --ssh-keygen-format=RFC4716
      --k8s-secret-name=flux-git-deploy
      --memcached-hostname=flux-memcached
      --sync-state=git
      --memcached-service=
      --git-url=https://$(GIT_AUTHUSER):$(GIT_AUTHKEY)@github.com/repo/path/gitops-helm-release-tf.git
      --git-branch=master
      --git-path=namespaces,components
      --git-readonly=false
      --git-user=Flux Operator
      --git-email=kevin.fernandes@example.com
      --git-verify-signatures=false
      --git-set-author=false
      --git-poll-interval=1m
      --git-timeout=20s
      --sync-interval=1m
      --git-ci-skip=true
      --git-label=shoot--example--test
      --automation-interval=1m
      --registry-rps=200
      --registry-burst=125
      --registry-trace=false
      --sync-garbage-collection=true

Additional context

linuxbsdfreak commented 4 years ago

The issue can be closed. It was due to an error at my end with special char in the token.