search

fluxcd / flux

Successor: https://github.com/fluxcd/flux2
https://fluxcd.io
Apache License 2.0
6.9k stars 1.08k forks source link

Skip AWS Metadata API pre-flight check when regions are passed via config #3485

Closed kingdonb closed 3 years ago

kingdonb commented 3 years ago

Replaces #3124

Reportedly fixes #3015

Thanks to @evq and sorry for the delay. ~I'll see if we can get this in 1.23.0.~ This is planned to be included now in 1.23.2.

Since this issue sat for a while and had lots of discussion, I had to research it again. The best summary of who is affected is here:

https://github.com/fluxcd/flux/pull/3124#issuecomment-644832582

The short version is, if you are following best-practices with EKS+IRSA, and still using Flux v1 with its image update automation feature on ECR, then it probably affects you. I don't have any reason to think there's any potential this fix could represent a breaking change.

gonzalobarbitta commented 3 years ago

I was running into the same issue as #3124, but using ec2 instead of Fargate. This change solved my problem too.

kingdonb commented 3 years ago

~I don't know the root cause (other than, apparently failure to communicate with the AWS API, which might be more common than I originally understood while reviewing this PR)~ I updated the PR body with what I know about the root cause.

After reviewing the issue with @gonzalobarbitta I see this as a bugfix with little to no potential for breakage, and I will plan to include it in the next patch release.

Thanks very much for collaborating on this 👍 💯