search

fluxcd / flux

Successor: https://github.com/fluxcd/flux2
https://fluxcd.io
Apache License 2.0
6.9k stars 1.08k forks source link

Add access to `--git-verify-signatures-mode` from Helm #3603

Closed julienduchesne closed 2 years ago

julienduchesne commented 2 years ago

This is retro-compatible with previous versions (won't cause a new deployment without specifically setting the config) It allows a user to set the --git-verify-signatures-mode option instead of the deprecated --git-verify-signatures which is currently always set

kingdonb commented 2 years ago

Thanks for submitting a PR! I think this looks OK to merge and include in the next chart release.

There's nothing objectionable or not backwards compatible, and it simply continues advancing forward with the deprecation that was already made in Flux daemon. 👍

I'm marking this for the next milestone. Unsure when that will be, but likely within the next few weeks.

kingdonb commented 2 years ago

This may take some time to get merged and released, as I'll want to do this carefully and make sure I have tested it.

At a glance it does look like it should be backwards-compatible. We can do a chart release without doing a full release and build, but as the releases have got less frequent, I suspect there is likely a fresh backlog of CVE scan warnings I'll need to catch up with, and it might be worthwhile publishing a 1.25.1 release with no changes, only a fresh build that happens against the next newest alpine which is 3.15.4.

kingdonb commented 2 years ago

I will rebase and merge this to release with the next chart, coming out together with the 1.25.1 flux daemon image 👍