search

fluxcd / flux2-kustomize-helm-example

A GitOps workflow example for multi-env deployments with Flux, Kustomize and Helm.
https://fluxcd.io
Apache License 2.0
935 stars 992 forks source link

podinfo HelmRepository in wrong namespace #30

Closed johngmyers closed 3 years ago

johngmyers commented 3 years ago

There is a discrepancy in the example that confuses me:

infrastructure/sources/podinfo.yaml does not specify a namespace, so the HelmRepository is placed in the default namespace.

apps/base/podinfo/release.yaml specifies as its sourceRef a HelmRepository named podinfo but in the flux-system namespace.

Should these two not refer to the same namespace?

stefanprodan commented 3 years ago

infrastructure/sources/podinfo.yaml does not specify a namespace, so the HelmRepository is placed in the default namespace.

The namespace is set here https://github.com/fluxcd/flux2-kustomize-helm-example/blob/main/infrastructure/sources/kustomization.yaml#L3

johngmyers commented 3 years ago

Thanks. I missed that subtlety when simplifying.