search

fluxcd / flux2-kustomize-helm-example

A GitOps workflow example for multi-env deployments with Flux, Kustomize and Helm.
https://fluxcd.io
Apache License 2.0
935 stars 992 forks source link

Add explicit namespace to work with SSA #42

Closed darkowlzz closed 2 years ago

darkowlzz commented 2 years ago

Since SSA requires explicit namespace, the manifests result in error namespace not specified. Update the manifests with explicit namespace to work with the latest flux.

stefanprodan commented 2 years ago

This repo is used for flux2 e2e testing, it should’ve blocked the release. How did you determined it’s failing?

PS. The namespaces are set for each object in their kustomize overlay.

darkowlzz commented 2 years ago

This repo is used for flux2 e2e testing, it should’ve blocked the release. How did you determined it’s failing?

I didn't actually run the whole thing. I was just referring to the code snippets in the readme as examples for testing, since this is an example repo. Not sure if others also use it that way.

Please close this PR if that's not how it's supposed to be used.

stefanprodan commented 2 years ago

Closing as the metadata.namespace field is set for all resources using kustomize namespace transformers, there is no need to specify the namespace in each file.