search

fluxcd / flux2-monitoring-example

Prometheus monitoring for the Flux control plane
https://fluxcd.io/flux/monitoring/
Apache License 2.0
52 stars 145 forks source link

Update Flux Control Plane Grafana dashboard and kube-prometheus-stack to 55.x #20

Closed mjtrangoni closed 10 months ago

mjtrangoni commented 10 months ago

Hi,

This is a trivial PR, fixing two nits in the Flux Control Plane Grafana dashboard.

  1. Panel Helm Releases ops/min was still of type Graph (old), and this PR updated it to timeseries.
  2. Update kube-prometheus-stack from 54.x to 55.x

Let me know if I need to adjust something else.

Thank you!

Mario

stefanprodan commented 10 months ago

Can you please bump the version to 55.x in here https://github.com/fluxcd/flux2-monitoring-example/blob/913084eb4a4e7463800f6bb3361b8302b74a1b4c/monitoring/controllers/kube-prometheus-stack/release.yaml#L9

mjtrangoni commented 10 months ago

@stefanprodan done. Thank you

mjtrangoni commented 10 months ago

@darkowlzz Thanks for your review. I just dropped my commit about the container labels, so we can merge this.

For the records, I'm running Rancher Desktop on my M1, with k8s version v1.28.4+k3s2 and missing the container label completely.

darkowlzz commented 10 months ago

Found some more information and workaround for the issue in this rancher issue thread, and the latest version of rancher may have a fix for it, not sure about rancher desktop. It seems the underlying issue will be addressed by this KEP in the future, with CRI getting all the necessary information about the containers and pods.