search

fluxcd / flux2-multi-tenancy

Manage multi-tenant clusters with Flux
Apache License 2.0
500 stars 250 forks source link

Align multi-tenancy lockdown with documentation #116

Closed XSpielinbox closed 1 year ago

XSpielinbox commented 1 year ago

The README.md of this project, as well as the kustomization.yaml of production and staging use one version of the multi-tenancy lockdown patch.

The flux documentation (source) uses a different version however.

The differences are:

  1. gotk-components.yaml and gotk-sync.yaml are correctly indented in the docs, whereas indentation seems wrong here.
  2. In the docs the paths are /spec/template/spec/containers/0/args/-, here they are /spec/template/spec/containers/0/args/0.
  3. The docs include an additional section that sets --no-remote-bases=true.

All in all, the version in the docs seems more up to date. Please correct me, if this assumption is wrong. I can also create an issue in the website repo as necessary.

It would be really nice, if there would be one version used everywhere. Having different versions without explanation is very confusing.

To avoid this in the future it might be better to avoid the code duplication.

XSpielinbox commented 1 year ago

Thank you!