fluxcd / go-git-providers

Git provider client for Go
https://fluxcd.io
Apache License 2.0
72 stars 34 forks source link

Make logger optional in Stash client #209

Closed makkes closed 1 year ago

makkes commented 1 year ago

In this discussion it was reported that the Flux CLI fails to bootstrap a Bitbucket Server/Stash repository. The reason is that no logger is passed to the client but a logger is required for the client to work. This, in conjunction with this change in logr led to the bug experienced in the Flux CLI.

It should be up to the consumer of the GGP API whether to pass in a logger or not so it should be made truly optional.

related to fluxcd/flux2#3808