search

fluxcd / go-git-providers

Git provider client for Go
https://fluxcd.io
Apache License 2.0
71 stars 33 forks source link

Adapt workflows #261

Closed souleb closed 5 months ago

souleb commented 5 months ago

Description

Adapting github action workflows to have the same behaviour across providers.

darkowlzz commented 5 months ago

oh my approval doesn't count in this repository :smile: But the DCO check is failing https://github.com/fluxcd/go-git-providers/pull/261/checks?check_run_id=20865958577. For some reason it expects your old email address for sign-off.

stefanprodan commented 5 months ago

No idea how to fix the DCO bot, it's really annoying.

darkowlzz commented 5 months ago

If you look at https://patch-diff.githubusercontent.com/raw/fluxcd/go-git-providers/pull/261.patch, the commit was authored using the old email address. Maybe that is what's causing this conflict. Updating the git email address in ~/.gitconfig should commit using the new email address and hopefully fix this.