search

fluxcd / go-git-providers

Git provider client for Go
https://fluxcd.io
Apache License 2.0
72 stars 34 forks source link

Update dependencies #286

Closed souleb closed 2 months ago

souleb commented 3 months ago

Description

Update dependencies, notably github.com/google/go-github/v64.

souleb commented 3 months ago

gitlab tests keep failing. I tried a new version locally without success. @makkes any idea?

makkes commented 3 months ago

gitlab tests keep failing. I tried a new version locally without success. @makkes any idea?

I'll take a look.

makkes commented 3 months ago

I was able to find out that the failures start appearing with github.com/xanzy/go-gitlab v0.106.0 and v0.105.0 still works. Need to dig deeper what changed in 106.

makkes commented 3 months ago

I bisected the upstream codebase and identified the bad commit to be https://github.com/xanzy/go-gitlab/commit/f49ba027968b5a34c4f925e885c91a09e50a16df. I suppose we're depending on a specific type of error to be returned.

makkes commented 3 months ago

@souleb I pushed a commit to fix the e2e errors for GitLab. Please see the commit message for an explanation. It's awful. 🤦🏻‍♂️ They just changed the API surface in a breaking way.

makkes commented 3 months ago

There seems to be one case missing somewhere but I don't have time today to dig into it.

stefanprodan commented 2 months ago

Let's go with go-gitlab v0.105.0 if that's the most recent version that works for us.

stefanprodan commented 2 months ago

I fixed the GitLab breaking changes, but now GitHub broke their public API, the fix is here https://github.com/google/go-github/issues/3248 with no release for it. I will try pin go-github to main.