Closed souleb closed 5 months ago
Tested this on a kind cluster:
drifted configmap
{"level":"debug","ts":"2024-06-18T21:48:05.588Z","msg":"resource modified","controller":"helmrelease","controllerGroup":"helm.toolkit.fluxcd.io","controllerKind":"HelmRelease","HelmRelease":{"name":"podinfo","namespace":"default"},"namespace":"default","name":"podinfo","reconcileID":"622968d9-00df-4254-b812-992a9f1b62eb","patch":[{"value":"maxmemory 64mb\nmaxmemory-policy allkeys-lru\nsave \"\"\nappendonly no\n","op":"replace","path":"/data/redis.conf"}],"resource":"ConfigMap/default/podinfo-redis"}
**drifted deployment***
{"level":"debug","ts":"2024-06-18T21:28:23.163Z","msg":"resource modified","controller":"helmrelease","controllerGroup":"helm.toolkit.fluxcd.io","controllerKind":"HelmRelease","HelmRelease":{"name":"ww-gitops","namespace":"flux-system"},"namespace":"flux-system","name":"ww-gitops","reconcileID":"6079f6e4-0fff-4b48-b58d-3efcc7023773","patch":[{"value":1,"op":"replace","path":"/spec/replicas"}],"resource":"Deployment/flux-system/ww-gitops-weave-gitops"}
Successfully created backport PR for release/v1.0.x
:
fix #1008
We previously disabled logging json patches on
ReleaseStatusDrifted
due to the fact that theMaskSecretPatchData()
cannot differentiate betweenSecrets
andConfigMaps
in #935We are re-enabling this with a check on the
kind
to know when to callMaskSecretPatchData()
.