Implement deletion retries

fluxcd / helm-controller

The GitOps Toolkit Helm reconciler, for declarative Helming

https://fluxcd.io

Apache License 2.0

407 stars 160 forks source link

Implement deletion retries #291

Open dippynark opened 3 years ago

dippynark commented 3 years ago

If a HelmRelease is deleted and fails to delete corresponding resources (e.g. failed webhook or missing CRD) it is never retried and just leaves orphaned resources.

If this functionality is lacking in the Helm Go library this can be accomplished using owner references.

JaneLiuL commented 3 years ago

I would like to take this issue. Please let me to have a try.

dippynark commented 3 years ago

@JaneLiuL great, after some more thought, I think to do this properly you'll need to inspect the Secrets that Helm uses to store state as mentioned: https://github.com/fluxcd/helm-controller/issues/292#issuecomment-875402195

This may require a certain amount of ground work