WIP: don't install CRDs of disabled subcharts

fluxcd / helm-controller

The GitOps Toolkit Helm reconciler, for declarative Helming

https://fluxcd.io

Apache License 2.0

398 stars 157 forks source link

WIP: don't install CRDs of disabled subcharts #941

Open MBrouns opened 3 months ago

MBrouns commented 3 months ago

Possible solution for #938

souleb commented 3 months ago

This results in helmchartutil.ProcessDependenciesWithMerge being called twice. We need a test case for idempotence here.

MBrouns commented 3 months ago

I can put in some time tomorrow or Thursday I think to write test cases and do it on upgrade as well. Any other concerns that need to be addressed?

stefanprodan commented 3 months ago

We need a test case for idempotence here.

Reading this I hope we are safe:

https://github.com/helm/helm/blob/main/pkg/chartutil/dependencies.go#L208-L211
https://github.com/helm/helm/blob/main/pkg/chartutil/dependencies.go#L303-L315

In any case, if anywhere in that logic a map from the chart is touched, calling the function twice will mess up the whole thing, so we really need a test.