search

fluxcd / helm-controller

The GitOps Toolkit Helm reconciler, for declarative Helming
https://fluxcd.io
Apache License 2.0
407 stars 160 forks source link

Fix: Make `HelmChartTemplate` a pointer in `.spec.chart` #980

Closed souleb closed 4 months ago

souleb commented 4 months ago

If implemented, this will omit empty .spec.chart in rendered yamls.

Required for: https://github.com/fluxcd/flux2/pull/4766

fluxcdbot commented 4 months ago

Successfully created backport PR for release/v1.0.x:

seaneagan commented 4 months ago

@souleb @stefanprodan this is a breaking change to the v2beta2 types when using the api go module, just checking if that's something that needs to be documented in the changelog.

stefanprodan commented 4 months ago

@seaneagan if you need v2beta2 stay on api v0.x. In v1.0.0 we have deprecated v2beta2, no one should use it with this version.