fluxcd / helm-controller

The GitOps Toolkit Helm reconciler, for declarative Helming
https://fluxcd.io
Apache License 2.0
414 stars 163 forks source link

doc: fix HelmRelease default value for `.spec.upgrade.crds` #986

Closed sestegra closed 6 months ago

sestegra commented 6 months ago

In the HelmRelease documentation, the default value for .spec.upgrade.crds is set as None in Upgrade configuration part, then the default value is set as Skip in Controlling the lifecycle of Custom Resource Definitions part.

sestegra commented 6 months ago

@stefanprodan Update done

fluxcdbot commented 6 months ago

Backport failed because this pull request contains merge commits. You can either backport this pull request manually, or configure the action to skip merge commits.

stefanprodan commented 6 months ago

Ah I haven't noticed the merge commit... @souleb we need to figure out a way to block users from doing this.

sestegra commented 6 months ago

Sorry for the extra manual labor, I owe you a drink I found some open discussions about this issue, but no solutions found yet.