search

fluxcd / helm-operator

Successor: https://github.com/fluxcd/helm-controller — The Flux Helm Operator, once upon a time a solution for declarative Helming.
https://docs.fluxcd.io/projects/helm-operator/
Apache License 2.0
649 stars 262 forks source link

Remove the query string from the CleanURL #571

Closed smarthall closed 3 years ago

smarthall commented 3 years ago

We are using Azure Blob storage as a private Helm repository. As described here. This breaks in helm-operator because the SAS token makes the cache directory too long and it fails with the following message:

synchronization of release 'demo' in namespace 'default' failed: failed to prepare chart for release: chart unavailable: mkdir /tmp/v3/[LONG FILE NAME]: file name too long

This PR strips the query string from the repo url that is used for caching so that:

  1. If the authentication token changes the same cache can still be used.
  2. The directory name is shorter
smarthall commented 3 years ago

You are welcome, thanks for merging it.

I've rebased onto the latest master.