fluxcd / image-automation-controller

GitOps Toolkit controller that patches container image tags in Git
https://fluxcd.io
Apache License 2.0
155 stars 67 forks source link

Adding tests for accept function in the filter package #633

Closed zhaque44 closed 5 months ago

zhaque44 commented 5 months ago

Tests for Accept - Scalar Node:

Description: Tests the accept function when provided with a scalar node and valid setter schema. The function should not return an error (assert.NoError). The expected error value should be false (assert.Equal).

Tests for Accept - Scalar Node - Error:

Description: Tests the accept function when provided with a scalar node, with invalid setter schema. The function should not return an error (assert.NoError). The expected error value should be true (assert.Equal).

stefanprodan commented 5 months ago

Please rebase with upstream main and force push, this PR should have a single commit before we can merge it. Thanks

zhaque44 commented 5 months ago

Please rebase with upstream main and force push, this PR should have a single commit before we can merge it. Thanks

ive made an error, im opening a new pr