This release primarily includes fixes for spurious errors we hit when
checking that directories created by MkdirAll "look right". Upon further
consideration, these checks were fundamentally buggy and didn't offer
any practical protection anyway.
The mode and owner verification logic in MkdirAll has been removed. This
was originally intended to protect against some theoretical attacks but upon
further consideration these protections don't actually buy us anything and
they were causing spurious errors with more complicated filesystem setups.
The "is the created directory empty" logic in MkdirAll has also been
removed. This was not causing us issues yet, but some pseudofilesystems (such
as cgroup) create non-empty directories and so this logic would've been
wrong for such cases.
Thanks to all of the contributors who made this release possible:
The mode and owner verification logic in MkdirAll has been removed. This
was originally intended to protect against some theoretical attacks but upon
further consideration these protections don't actually buy us anything and
they were causing spurious errors with more complicated filesystem setups.
The "is the created directory empty" logic in MkdirAll has also been
removed. This was not causing us issues yet, but some pseudofilesystems (such
as cgroup) create non-empty directories and so this logic would've been
wrong for such cases.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
- `@dependabot ignore minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
- `@dependabot ignore ` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore ` will remove all of the ignore conditions of the specified dependency
- `@dependabot unignore ` will remove the ignore condition of the specified dependency and ignore conditions
dependabot[bot]
commented
1 month ago
Bumps the go-deps group with 2 updates in the / directory: github.com/ProtonMail/go-crypto and github.com/cyphar/filepath-securejoin.
Updates
github.com/ProtonMail/go-cryptofrom 1.1.0-alpha.5-proton to 1.1.0-beta.0-protonRelease notes
Sourced from github.com/ProtonMail/go-crypto's releases.
Commits
b04e354Fix HMAC generation (#204)85bc845Replace ioutil.ReadAll with io.ReadAll5f49c73fix(v2): Adapt NewForwardingEntity to refactored NewEntity9aa010afix(v2): Do not allow encrpytion with a forwarding key91c2e9efeat: Add symmetric keys to v23f6d02afix: Address warningsda0a0cffeat: Add forwarding to v2 api0e6a359fix: Address rebase on version 2 issuesc602a74Use fingerprints instead of KeyIDs348b81dCreate a copy of the encrypted key when forwardingUpdates
github.com/cyphar/filepath-securejoinfrom 0.3.2 to 0.3.3Release notes
Sourced from github.com/cyphar/filepath-securejoin's releases.
Changelog
Sourced from github.com/cyphar/filepath-securejoin's changelog.
Commits
93cff46VERSION: release v0.3.32b3d97dmerge #26 into cyphar/filepath-securejoin:main09afcf2OpenInRoot: add CVE link to godoc5b5a7a4Add cross-links to godocdaead99Remove osVFS methods documentation208ded3tests: don't panic if the fd is closed626b5a5merge #29 into cyphar/filepath-securejoin:main92b699dmkdir: don't check that the directory is empty90adf5cmkdir: do not return errors for incorrect directory modes or owners3bf6419merge #30 into cyphar/filepath-securejoin:mainDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show