fluxcd / image-reflector-controller

GitOps Toolkit controller that scans container registries
https://fluxcd.io
Apache License 2.0
109 stars 67 forks source link

Confusing error message about successful image scan #356

Open tun0 opened 1 year ago

tun0 commented 1 year ago

This is tad confusing:

jsonPayload: {
  ImageRepository: {2}
  controller: "imagerepository"
  controllerGroup: "image.toolkit.fluxcd.io"
  controllerKind: "ImageRepository"
  error: "Succeeded"
  level: "error"
  msg: "successful scan: found 8 tags"
  name: "huurwoningen-referrer-revenue"
  namespace: "flux-system"
  reconcileID: "a999f75e-e3de-40e6-a80b-f68095301532"
  ts: "2023-03-10T09:18:27.127Z"
}

The fact that it succeeded is an error? :shrug:

It was followed by this:

jsonPayload: {
  ImageRepository: {2}
  controller: "imagerepository"
  controllerGroup: "image.toolkit.fluxcd.io"
  controllerKind: "ImageRepository"
  error: "timed out waiting for the condition"
  errorCauses: [1]
  level: "error"
  msg: "Reconciler error"
  name: "huurwoningen-referrer-revenue"
  namespace: "flux-system"
  reconcileID: "a999f75e-e3de-40e6-a80b-f68095301532"
  ts: "2023-03-10T09:18:27.316Z"
}
tun0 commented 1 year ago

See also this thread on Slack.

darkowlzz commented 1 year ago

A fix for this is in #357. We have an RC build based on v0.26.0/latest main to try this

ghcr.io/fluxcd/image-reflector-controller:rc-b89a023e@sha256:377a7bc1cf45b4245a82c21be149d8784c8cd74c5c1bc65188e68c28fcbd5dc0

Build logs https://github.com/fluxcd/image-reflector-controller/actions/runs/4417823595. It should be compatible with v0.25.0 as well. Please give it a try and let us know if the issue still persists.

tun0 commented 1 year ago

Deployed the RC build yesterday. Given the issue hasn't resurfaced in the last few days, and I don't know how to trigger it, validating the fix might prove to be a tad tricky :wink: