The Mark… functions in the conditions package accept a format string and (optional) arguments, just like fmt.Printf and friends.
In many places, the code passed an error message as the format string, causing it to be interpreted as a format string by the fmt package. This leads to issues when the message contains percent signs, e.g. URL-encoded values.
This PR adds a format string and shortens err.Error() to err, which yields the same output.
This change is identical in principle to fluxcd/source-controller#1529.
The
Mark…
functions in theconditions
package accept a format string and (optional) arguments, just likefmt.Printf
and friends.In many places, the code passed an error message as the format string, causing it to be interpreted as a format string by the
fmt
package. This leads to issues when the message contains percent signs, e.g. URL-encoded values.This PR adds a format string and shortens
err.Error()
toerr
, which yields the same output.This change is identical in principle to fluxcd/source-controller#1529.