fluxcd / pkg

Toolkit common packages
https://pkg.go.dev/github.com/fluxcd/pkg
Apache License 2.0
48 stars 84 forks source link

git: Requirements to move back to `go-git/go-git` #397

Open pjbgf opened 1 year ago

pjbgf commented 1 year ago

The go-git/go-git dependency has recently been replaced with fluxcd/go-git`. In order to be able to move back to the upstream project, we need:

Upstream performance improvements

Upstream behaviour changes

pjbgf commented 1 year ago

Runnign the tests using upstream go-git version (v5.6.0) breaks two tests:

  1. Test_SOCKS5_proxy
  2. Test_HTTP_proxy/env_var:_HTTPS_PROXY

The former is fixed by https://github.com/go-git/go-git/pull/655. The latter will require the upstreaming of https://github.com/fluxcd/go-git/pull/9.