search

fluxcd / pkg

Toolkit common packages
https://pkg.go.dev/github.com/fluxcd/pkg
Apache License 2.0
48 stars 85 forks source link

Adding common "reason" constants #723

Closed gdasson closed 6 months ago

gdasson commented 8 months ago

Adding "reason" constants to the pkg repo as suggested in this PR: https://github.com/fluxcd/notification-controller/pull/701

This will be followed by a PR in kustomize controller to refer to these constants from common pkg repo here and updates to the above mentioned PR to do the same.

gdasson commented 8 months ago

@darkowlzz : Thanks for the review. I have incorporated your review comments: rebased, fixed and squashed my commits as well. Please review again and let me know if more updates are required. thx.

gdasson commented 7 months ago

@stefanprodan , @hiddeco : Could you please review this PR? Its pending your review and approval. Thanks.

stefanprodan commented 6 months ago

@gdasson please rebase with main and force push.

gdasson commented 6 months ago

@stefanprodan: Done.