Closed stefanprodan closed 1 year ago
This would require changes to fluxcd/pkg/git
to allow the annotated tag object in Git to be verified. As the place where the signature is found is different from commits (the raw Git commit object has a gpgsig
field, for the tag it's expected as the first signature found at the bottom of the annotation message).
In addition, the reconciler would require changes to work with tag objects as well, as it currently assumes to work with a git.Commit
object throughout the code.
Flux should be able to verify signed tags, currently if I push a signed tag, Flux looks at HEAD, making it impossible to verify releases from GitHub as GH merge-commits are not signed by authors, only tags are.
Example:
This errors out with:
The
fcf573111bd82600052f99195a67f33d8242bf17
commit is of HEAD, Flux should verifydd3869b1a177432b60ea1e3ba99c10fc9db850fa
which is the signed tag.