Validate kubeconfig during provider configuration. - Githubissues

fluxcd / terraform-provider-flux

Terraform and OpenTofu provider for bootstrapping Flux

https://registry.terraform.io/providers/fluxcd/flux/latest

Apache License 2.0

336 stars 89 forks source link

Validate kubeconfig during provider configuration. #658

Closed swade1987 closed 1 month ago

swade1987 commented 1 month ago

Description

Validate kubernetes connectivity during provider configuration to reduce errors later on.

Motivation and Context

Fixes #656

How has this been tested?

[x] Have you added an acceptance test for the functionality being added?
[x] Have you run the acceptance tests on this branch?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Documentation

[x] I have updated the documentation (if required) with make docs

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritise this request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

networkhermit commented 1 month ago

I notice that the validate logic triggers a ServiceAccountList request in default namespace. I don't know, but is it possible for it to get reported and marked by some audit framework? If that's the case, ServiceList or else would be more harmless candidate. (Correct me if it's just me being over cautious.)