fluxionary / minetest-moreblocks

More Blocks
https://content.minetest.net/packages/Calinou/moreblocks/
Other
3 stars 2 forks source link

Techage and other mods compatibility issue: thousands of WARNING: removing group overrides #21

Open Pivert opened 10 months ago

Pivert commented 10 months ago

Stairsplus generates a massive amount of WARNING at startup :

$k logs minetestserver-0 | grep WARNING | wc -l
3717
22:40:29[Z690-seashell-489691][pivert](master) [ctx:def/ns:minetest] /workdir/LocalDocuments/pivertIaC/k8s/minetest
$k logs minetestserver-0 | grep WARNING | grep stairsplus | wc -l
3528

So 3528 lines in a minute... 90% of startup WARNING messages.

A few lines:

WARNING[Main]: [stairsplus] removing group overrides from techage:stair_cement_block_half (was {"cracky":2.0,"not_in_creative_inventory":1.0,"stone":1.0}, will be {"cracky":2.0,"shape_stair_half":1.0,"stair_stone_half":1.0})
WARNING[Main]: [stairsplus] removing group overrides from techage:slope_bauxite_cobble_inner_half_raised (was {"cracky":3.0,"not_in_creative_inventory":1.0,"stone":2.0}, will be {"cracky":3.0,"shape_slope_inner_half_raised":1.0,"slope_stone_inner_half_raised":2.0})
WARNING[Main]: [stairsplus] removing group overrides from castle_masonry:slope_stonewall_half (was {"cracky":3.0,"not_in_creative_inventory":1.0,"pickaxey":1.0}, will be {"cracky":3.0,"pickaxey":1.0,"shape_slope_half":1.0})
fluxionary commented 6 months ago

these warnings are to indicate that the groups of the stairsplus nodes will be different than the groups of the equivalent nodes from the "old" moreblocks fork. if you want the warnings to go away, change the way that those mods register things to use the new stairsplus API.

EDIT: apologies for forgetting to reply to this earlier.

Pivert commented 5 days ago

Hi,

change the way that those mods register things => So as a mod user, we have to keep using it like this ? Would I be the only concerned by such an amount of noise in the logs ?

fluxionary commented 2 days ago

Would I be the only concerned by such an amount of noise in the logs ?

you're not the only one. i do know server owners that don't like having such error/warnings in their logs, but i don't know a better way to communicate that some things are just slightly "broken" by this fork (i'm not aware of any mods that depend on the old behavior, but it's not impossible). probably i should allow these messages to be disabled with a setting...

fluxionary commented 2 days ago

i added a setting (stairsplus.silence_group_overrides, see https://github.com/fluxionary/minetest-moreblocks/commit/7c0a75071c0ed815c5e28cf0b9cda40bb62db218). i haven't actually tested it; would you mind being my QA? if you enable that setting, the messages warnings should disappear.