fluxnet / ONEFlux

Open Network-Enabled Flux processing pipeline
Other
74 stars 40 forks source link

Error linking ure #55

Closed pisaac-ozflux closed 2 weeks ago

pisaac-ozflux commented 1 year ago

Hi ONEFluxers,

I'm getting some errors when using make -f Makefile in ONEFlux/oneflux_steps at the linking of ure. The screen output with the error is below.

gcc -O3 dataset.o main.o /home/peter/Development/ONEFlux/oneflux_steps/common/common.o -w -lm -o /home/peter/bin/oneflux/ure /usr/bin/ld: main.o:(.data.rel.local+0x0): multiple definition of authors_suffix'; dataset.o:(.bss+0x0): first defined here /usr/bin/ld: main.o:(.data.rel.local+0x20): multiple definition oftypes_suffix'; dataset.o:(.bss+0x20): first defined here collect2: error: ld returned 1 exit status make: *** [Makefile:174: /home/peter/bin/oneflux/ure] Error 1

OS is Ubuntu 22.04 and gcc version is 11.3.0. It links OK on Ubuntu 20.04 and gcc 9.4.0.

Many thanks for all your hard work on ONEFlux.

Cheers, Peter

gilbertozp commented 1 year ago

Hi @pisaac-ozflux, thank you for raising this issue. I believe this is something we already know about (Issue #24) and will be fixed in the next release (changes in PR #27). We should have news on this in the coming days, and we can check in again.

pisaac-ozflux commented 1 year ago

Thanks, Gilberto!

pisaac-ozflux commented 2 weeks ago

Still occurring with latest version cloned today. Putting "-fcommon" in the compile command for ure in oneflux_steps/Makefile is a workaround.

Looking forward to catching up in Berkeley, Gilberto!

gilbertozp commented 2 weeks ago

Thank you @pisaac-ozflux, We're merging our changes, this one should be resolved now (with a change in variable declarations instead of compiler options). Looking forward to seeing you as well, safe travels!

pisaac-ozflux commented 2 weeks ago

👍👍👍 You've been busy, Gilberto! Many PR merges on a Sunday afternoon ...

P.

On Mon, 2 Sept 2024 at 10:01, Gilberto Pastorello @.***> wrote:

Thank you @pisaac-ozflux https://github.com/pisaac-ozflux, We're merging our changes, this one should be resolved now (with a change in variable declarations instead of compiler options). Looking forward to seeing you as well, safe travels!

— Reply to this email directly, view it on GitHub https://github.com/fluxnet/ONEFlux/issues/55#issuecomment-2323550719, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTSJCNT3YI7SVYY7TODKETZUOTGJAVCNFSM6AAAAABNOS3OKKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRTGU2TANZRHE . You are receiving this because you were mentioned.Message ID: @.***>

-- Peter Isaac Ph: +61 3 59685998 Mob: 0429053970 Skype: pisaac.ozflux Email: @.***

"Vita brevis, ars longa, occasio praeceps, experimentum periculosum, iudicium difficile" - Hippocrates 400BC "What's the go o'that?" - James Clerk Maxwell c1835 "'Reality,' sa Molesworth 2,' is so unspekeably sordid it make me shuder.'"