fluxninja / aperture

Rate limiting, caching, and request prioritization for modern workloads
https://docs.fluxninja.com
Apache License 2.0
641 stars 25 forks source link

Make python sdk throw less exceptions #2979

Closed IridiumOxide closed 11 months ago

IridiumOxide commented 11 months ago

Description of change

Checklist

Summary by CodeRabbit

coderabbitai[bot] commented 11 months ago

Walkthrough

The updates to the Aperture SDK involve significant changes in error handling and resource management. Exception classes and the close method have been removed, suggesting a shift in how the SDK manages errors and cleans up resources. Additionally, the SDK now includes better error handling for gRPC calls, with specific response types for cache operations, and the introduction of state cache management methods.

Changes

File Path Change Summary
.../aperture_sdk/client.py
.../aperture_sdk/flow.py
- Removed RejectedFlowException, ApertureException, and close method.
- Updated start_flow to capture exceptions and modified wrapper to return on_reject result.
- Added grpc import and introduced error handling for gRPC calls.
- Updated return types for cache operations and added error handling.
- Added state cache management methods.

🐇✨ To the code that's been refined, Farewell to the errors entwined. With gRPC's embrace, We cache with more grace, And leave old exception paths behind. 🌟🚀


Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - If you reply to a *review comment* from CodeRabbit, the bot will automatically respond. - To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment - Note: Review comments are made on code diffs or files, not on the PR overview. - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Note: For conversation with the bot, please use the review comments on code diffs or files. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json`