Closed hdkshingala closed 11 months ago
The changes across various files seem to focus on code quality and consistency improvements. The use of strings.Compare
for string comparisons has been standardized, and there's an adjustment to error handling in the OpenTelemetry collector setup. Additionally, there's a suppression of static analysis warnings for deprecated gRPC interceptor functions, indicating a conscious decision to maintain current functionality despite deprecation notices.
Files | Summary |
---|---|
cmd/.../autoscale.go cmd/.../flowcontrol.go pkg/.../rollupprocessor/key.go |
Standardized string comparisons using strings.Compare . |
pkg/net/grpc/client.go pkg/net/grpc/server.go |
Suppressed static analysis warnings for deprecated gRPC interceptor functions with //nolint:staticcheck . |
pkg/otelcollector/otelcollector.go |
Modified CollectorSettings to expect a function returning factories and an error for initialization. |
🐇✨ In the realm of code, where the rabbits hop, We've tidied our strings, not a single flop. Though some tools may nag, with a
nolint
we block, And in telemetry's garden, we adjust the crop. 🌱🚀 🐇✨
Checklist
Summary by CodeRabbit
Refactor
strings.Compare
for consistency and reliability.Chores