fluxninja / aperture

Rate limiting, caching, and request prioritization for modern workloads
https://docs.fluxninja.com
Apache License 2.0
622 stars 24 forks source link

Update Termination Grace Period Seconds from operator #3024

Closed hdkshingala closed 9 months ago

hdkshingala commented 9 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 9 months ago

Walkthrough

The changes across various Go files involve the addition of logic to handle the TerminationGracePeriodSeconds field in Kubernetes DaemonSet and Deployment configurations. This field specifies the time allowed for a pod to shut down gracefully. Additionally, there's a refinement in the comments within a common types definition file, generalizing the description of the TerminationGracePeriodSeconds field from being specific to Redmine pods to all pods.

Changes

File Path Change Summary
.../agent/daemonset.go
.../agent/deployment.go
.../controller/deployment.go
Added logic to handle TerminationGracePeriodSeconds in DaemonSet and Deployment configurations.
.../api/common/common_types.go Updated comment for TerminationGracePeriodSeconds field to be more general.

🐇✨ In the land of code, where the daemons set,
A rabbit hopped in, no time to fret.
Graceful shutdowns, now neatly penned,
Pods can rest, as their time they spend.
🌟🌙


Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - If you reply to a *review comment* from CodeRabbit, the bot will automatically respond. - To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment - Note: Review comments are made on code diffs or files, not on the PR overview. - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Note: For conversation with the bot, please use the review comments on code diffs or files. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json`