fluxninja / aperture

Rate limiting, caching, and request prioritization for modern workloads
https://docs.fluxninja.com
Apache License 2.0
641 stars 25 forks source link

Remove deprecated `match_expressions` #3044

Closed kwapik closed 11 months ago

kwapik commented 11 months ago
Checklist

Summary by CodeRabbit

coderabbitai[bot] commented 11 months ago

Walkthrough

The recent updates involve the deprecation of match_expressions in favor of match_list for Kubernetes-style label matching. This change streamlines the label matching process by removing outdated code and documentation, ensuring that the system uses the updated match_list method exclusively.

Changes

File Path Change Summary
api/.../v1/label_matcher.proto Removed deprecated match_expressions
docs/.../spec.md Removed content related to deprecated match_expressions
pkg/.../selectors/selector.go Removed backCompatConvLabelMatcher function and updated MMExprFromLabelMatcher logic

Poem

🐇✨ In the code where labels dance,
Old expressions had no chance.
match_list now leads the prance,
A rabbit's cheer for the advance!
🎉🌟


Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - If you reply to a *review comment* from CodeRabbit, the bot will automatically respond. - To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment - Note: Review comments are made on code diffs or files, not on the PR overview. - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Note: For conversation with the bot, please use the review comments on code diffs or files. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json`