Engine tests

[hasit]

Description of change

Checklist

• [x] Tested in playground or other setup
• [ ] Screenshot (Grafana) from playground added to PR for 15+ minute run
• [ ] Documentation is changed or added
• [x] Tests and/or benchmarks are included
• [ ] Breaking changes

Summary by CodeRabbit

• New Features

  • Introduced the ability to adjust the capacity of concurrency limiters dynamically.
  • Enhanced concurrency scheduling with refined initialization and internal handling.
  • Improved the flow control engine's registration function for more precise callback handling.

• Bug Fixes

  • Streamlined concurrency test patterns to better reflect real-world usage.
  • Altered the flow control testing logic for more accurate expected request calculations.

• Refactor

  • Optimized internal concurrency limiter structure for increased efficiency and maintainability.
  • Refined the flow control engine's registration parameters for clarity and functionality.

• Tests

  • Added new test cases to validate registration and processing within the flow control engine.
  • Expanded unit tests to cover the new maximum inflight duration functionality without return.

• Chores

  • Updated .gitignore to better manage file tracking within the version control system.

[coderabbitai[bot]]

Walkthrough

The project has undergone a refactor that affects concurrency control, with changes in testing patterns, interface contracts, and internal logic for limiters and schedulers. A new method for setting capacity in the concurrency limiter interface has been introduced, and adjustments have been made to the registration function in the flow control engine. Additionally, the .gitignore file has been updated to better manage the repository's file tracking.

Changes

File Path	Summary of Changes
pkg/dmap-funcs/concurrency-limiter/*.go	Removal of requestRate, addition of shouldReturn, refactoring of runFlows, adjustment of checkResults, renaming of test function, addition of new subtest.
pkg/dmap-funcs/concurrency-limiter/iface.go	Addition of SetCapacity method to ConcurrencyLimiter interface.
pkg/policies/flowcontrol/actuators/concurrency-limiter/concurrency-limiter.go	Removal of inner field, refactoring of references to cl.inner, and changes in cl.inner initialization.
pkg/policies/flowcontrol/actuators/concurrency-scheduler/concurrency-scheduler.go	Modifications to concurrencyScheduler struct and usage of limiter field. Introduction of inner variable.
pkg/policies/flowcontrol/engine.go	Modification of register function parameters and matchedCB type.
.gitignore	Alterations to patterns for file tracking within the version control system.
pkg/policies/flowcontrol/engine_test.go	Addition of new imports, introduction of MockTestLimiter type, implementation of methods, and addition of test case for ProcessRequest.

Poem

🐇 "In the realm of code, where rabbits dare,
Changes hop through files with flair.
Concurrency tamed, tests refined,
A new chapter begins, with carrots aligned." 🥕

---

Tips

### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.