search

fluxninja / aperture

Rate limiting, caching, and request prioritization for modern workloads
https://docs.fluxninja.com
Apache License 2.0
645 stars 25 forks source link

Refactor Flow End in SDKs #3171

Closed hasit closed 9 months ago

hasit commented 9 months ago

Description of change

Checklist

Summary by CodeRabbit

coderabbitai[bot] commented 9 months ago

Walkthrough

The recent updates focus on optimizing the aperture-py, aperture-go, aperture-js, aperture-csharp, and aperture-java SDKs. The modifications across these SDKs streamline the code by introducing conditional checks and removing redundant lines to enhance efficiency and maintain code cleanliness.

Changes

File Path Change Summary
sdks/aperture-py/aperture_sdk/flow.py Modified end method to include conditional checks for decision.concurrency_limiter_info.request_id and decision.concurrency_scheduler_info.request_id.
sdks/aperture-py/aperture_sdk/flow_async.py Removed redundant lines.
sdks/aperture-go/sdk/flow.go Updated End method to skip processing if certain conditions are met, specifically checks for an empty RequestId in the ConcurrencyLimiterInfo and ConcurrencySchedulerInfo of each decision.
sdks/aperture-js/sdk/flow.ts Adjusted comparison for DECISION_TYPE_ACCEPTED and introduced additional conditional checks for decision.concurrencyLimiterInfo.requestId and decision.concurrencySchedulerInfo.requestId within the forEach loop.
sdks/aperture-csharp/Core/FeatureFlow.cs Added conditional checks to skip processing if certain RequestId values are empty.
sdks/aperture-java/lib/core/src/main/java/com/fluxninja/aperture/sdk/Flow.java Modified end method to include conditional checks for empty RequestId in ConcurrencyLimiterInfo and ConcurrencySchedulerInfo.
sdks/aperture-java/lib/core/src/main/java/com/fluxninja/aperture/sdk/TrafficFlow.java Added conditional checks to skip processing if certain fields are empty in the LimiterDecision objects.
sdks/aperture-go/sdk/httpflow.go Added conditional checks to skip processing if certain fields in the decision object are empty.

🐰✨
Changes here, changes there,
Cleaner code, everywhere.
When bugs do hide, we seek with care,
With every commit, we repair.
🌟🐾

Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.