Making Controller and Agent charts GitOps-friendlier

sadovnikov commented 10 months ago

Description of change

There are three small fixes in this PR

1) The default value of MutatingWebhookConfiguration.webhooks.rules.scope is '*'. However, it watches the namespaced resources only. Therefore, the result of kubectl diff detects a skew with the result of helm template, with the attempt to restore the default value.

2) Empty pullSecrets lists are ignored by kubectl diff. On the other hand, Helm does not provide a mechanism to remove default values from a dependency chart - they can only be replaced by other values.

3) The ttlSecondsAfterFinished deletes the post-install hook Job after 10 seconds. However, the Job is not annotated with hook-delete-policy. Therefore Argo CD is willing to restore the job.

Checklist

[x] Tested in playground or other setup
[ ] Screenshot (Grafana) from playground added to PR for 15+ minute run
[ ] Documentation is changed or added
[ ] Tests and/or benchmarks are included
[ ] Breaking changes

The changes were tested by deploying a chart with locally modified dependencies

dependencies:
- name: aperture-agent
  version: v2.34.0-rc.1
  repository: "file://aperture-agent"
#  repository: https://fluxninja.github.io/aperture/
  alias: agent
- name: aperture-controller
  version: v2.34.0-rc.1
  repository: "file://aperture-controller"
#  repository: https://fluxninja.github.io/aperture/
  alias: controller

coderabbitai[bot] commented 10 months ago

[!IMPORTANT]

Auto Review Skipped

Review was skipped due to path filters

Files ignored due to path filters (5)
* `manifests/charts/aperture-agent/templates/operator-mutatingwebhook.yaml` is excluded by: `!**/*.yaml` * `manifests/charts/aperture-agent/values.yaml` is excluded by: `!**/*.yaml` * `manifests/charts/aperture-controller/templates/operator-mutatingwebhook.yaml` is excluded by: `!**/*.yaml` * `manifests/charts/aperture-controller/templates/post-install-hook.yaml` is excluded by: `!**/*.yaml` * `manifests/charts/aperture-controller/values.yaml` is excluded by: `!**/*.yaml`

Tips

### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.