fluxoid-org / CyclismoProject

Contains all subprojects and libraries for the Cyclismo project
Other
7 stars 4 forks source link

upsample the data produced by BushidoBrake to 1Hz #58

Closed jovial closed 8 years ago

jovial commented 8 years ago

untested

dougszumski commented 8 years ago

Time to get on the turbo!

jovial commented 8 years ago

I'm interested to know if this fixes the strava speed fluctuation issue. Did #59 change the behaviour at all?

I implemented this in BushidoBrake as I wanted to make sure we are sending an updated virtual speed (virtual speed is obtained from polling the power model). We need to make sure we poll the power model with a zero speed when the turbo is stopped i.e we are no longer receiving ant packets.

Ideally we should implement turbo trainer capabilities (provides: power, speed etc) and have a precedence for power data. The power model could then be moved to a layer above the turbo trainer implementation.

jovial commented 8 years ago

Merged as I didn't want to include a major refactor as tracked in #60, #61 and #62.