search

fluxxcode / egui-file-dialog

Full featured and customizable file dialog for egui
MIT License
86 stars 11 forks source link

Configuration to allow overwriting files #101

Closed ThePuzzlemaker closed 5 months ago

ThePuzzlemaker commented 6 months ago

As the title says. I believe this should be a configurable option, instead of a fixed error.

fluxxcode commented 6 months ago

Thanks for the issue. Do you mean that when saving a file you can overwrite an existing one?

ThePuzzlemaker commented 6 months ago

Yes, currently it says something along the lines of "file already exists" when trying to select a file that already exists to overwrite.

crumblingstatue commented 6 months ago

Ideally it should ask in a modal dialog "The file already exists. Do you want to overwrite?", or something along those lines.

fluxxcode commented 5 months ago

I have now implemented the modal. Do you have any suggestions for improvement?

https://github.com/fluxxcode/egui-file-dialog/assets/55352293/a1f4aa30-3e4c-44b8-8378-3f8c57002498

crumblingstatue commented 5 months ago

That looks good, thank you! I'm gonna give it a test in my application.

One suggestion that comes to mind. Maybe "Abort" sounds a little dramatic. "Cancel" might be a better word to use.

fluxxcode commented 5 months ago

Changed and merged into develop 👍🏻